Implement AEIP2 update #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neylix
force-pushed
the
Implement-AEIP2-update
branch
from
210adb7
to
d28d553
Compare
Updated explorer UI to handle decimals, and display token symbol instead of address Also fixed bug of #560 |
| uco_price_at_time = tx.validation_stamp.timestamp |> OracleChain.get_uco_price() | ||
| uco_price_now = DateTime.utc_now() |> OracleChain.get_uco_price() | ||
|
|
||
| tokens = |
There was a problem hiding this comment.
If you want to reduce lines and avoid repetition you could use recursive function:
token_properties = []
|> get_token_addresses(ledger_inputs)
|> get_token_addresses(transaction_movements)
|> get_token_addresses(token_transfers)
|> Enum.uniq()
|> get_token_properties()
# ...
defp get_token_addresses(acc, [ %TransactionMovement{ type: {:token, token_address, _}} | rest ]) do
get_token_addresses([ token_address | acc ], rest)
end
defp get_token_addresses(acc, [ %TransactionInput{ type: {:token, token_address, _}} | rest]) do
get_token_addresses([ token_address | acc ], rest)
end
defp get_token_addresses(acc, [ %TokenTransfer{ token_address: token_address } | rest ]) do
get_token_addresses([ token_address | acc ], rest)
end
defp get_token_addresses(acc, _) do
get_token_addresses(acc, rest)
end
defp get_token_addresses(acc, []) do, do: acc
Neylix
force-pushed
the
Implement-AEIP2-update
branch
from
d28d553
to
8e298cc
Compare
samuelmanzanera
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the new version of AEIP2 (archethic-foundation/aeip@71d6e4f)
Fixes archethic-foundation/aeip#4 / archethic-foundation/aeip#9
Type of change
How Has This Been Tested?
Update test files
Creation of multiple NFT with or without collection, id, properties ...
Checklist: